Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): add buildTruncateAtEndStaticLayout impl #3988

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix(android): add buildTruncateAtEndStaticLayout impl #3988

merged 4 commits into from
Aug 14, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner August 7, 2024 09:05
@tencent-adm
Copy link
Member

tencent-adm commented Aug 7, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ siguangli2018
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Aug 7, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 7, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

iPel
iPel approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 7, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 7, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) August 7, 2024 09:47
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Aug 7, 2024
@siguangli siguangli disabled auto-merge August 14, 2024 06:21
@siguangli siguangli merged commit 9ba8426 into Tencent:main Aug 14, 2024
18 of 20 checks passed
@siguangli siguangli deleted the fix/ellipsizeTail branch August 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

Assignees
No one assigned
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siguangli @tencent-adm @iPel @siguangli2018 @open-hippy